Check for trivial cycles in persue_answer #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
jackh726
requested changes
May 22, 2020
chalk-engine/src/logic.rs
Outdated
| @@ -1328,11 +1314,23 @@ impl<'forest, C: Context + 'forest, CO: ContextOps<C> + 'forest> SolveState<'for | |||
| return None; | |||
| } | |||
|
|
|||
| let table = self.stack.top().table; | |||
There was a problem hiding this comment.
This is already in scope at the beginning of the function.
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
|
Potentially spurious error in CI, just gonna retry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that we do not add trivial coinductive goals to the answer at all and filter them in
pursue_answer. This allows us to have this check performed in a single place as @jackh726 was suggesting.Fix #313
Signed-off-by: Zahari Dichev zaharidichev@gmail.com