Add never type to TypeName
#466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
requested changes
May 21, 2020
There was a problem hiding this comment.
Copy/clone are in libcore: https://github.com/rust-lang/rust/blob/master/src/librustc_trait_selection/traits/select.rs#L2255
Also, looking over the table, looks like raw ptrs and immutable refs also have their impls in libcore. Think you can fix that here too? (It's small enough I don't think we need to split into a separate PR)
nathanwhit
force-pushed
the
typename-never
branch
from
8d0e10d to
13a7848
Compare
Whoops you're right, should be fixed now! |
jackh726
requested changes
May 21, 2020
nathanwhit
force-pushed
the
typename-never
branch
2 times, most recently
from
ec34892 to
3076dab
Compare
basil-cow
approved these changes
May 22, 2020
jackh726
requested changes
May 22, 2020
nathanwhit
force-pushed
the
typename-never
branch
from
3076dab to
2cb1d43
Compare
jackh726
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #368