Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opaque Type Generics #464

Merged
merged 4 commits into from
May 22, 2020
Merged

Opaque Type Generics #464

merged 4 commits into from
May 22, 2020

Conversation

nathanwhit
Copy link
Member

This PR picks up where #402 left off, and the failing test case from that PR now passes.

@detrumi detrumi mentioned this pull request May 21, 2020
Closed
@nathanwhit nathanwhit force-pushed the opaque-ty-generics branch from 0918102 to 5e5e4b1 Compare May 21, 2020 15:30
detrumi
detrumi approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@detrumi detrumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! This looks correct to me, though it makes me wonder whether we're missing similar interactions other than Projection.

@detrumi detrumi mentioned this pull request May 21, 2020
Open
@detrumi detrumi merged commit eaab84b into rust-lang:master May 22, 2020
@sluongng sluongng mentioned this pull request May 23, 2020
Closed
@nathanwhit nathanwhit deleted the opaque-ty-generics branch May 25, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flodiebold flodiebold flodiebold left review comments

@detrumi detrumi detrumi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanwhit @flodiebold @detrumi