Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slice type to TypeName #443

Merged
merged 6 commits into from
May 9, 2020
Merged

Add slice type to TypeName #443

merged 6 commits into from
May 9, 2020

Conversation

nathanwhit
Copy link
Member

Closes #440.

jackh726
jackh726 requested changes May 8, 2020
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add explicit tests that slices are not copy or clone?

@nathanwhit
Copy link
Member Author

Can you add explicit tests that slices are not copy or clone?

Done!

@jackh726
Copy link
Member

jackh726 commented May 9, 2020 •
edited
Loading

@nathanwhit can you rebase? And then also update the well known types table for refs since I didn't think about it before I merged your other PR 🤦‍♀️

jackh726
jackh726 approved these changes May 9, 2020
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwhit
Copy link
Member Author

@nathanwhit can you rebase? And then also update the well known types table for refs since I didn't think about it before I merged your other PR 🤦‍♀️

Rebased and updated the table! Should be good to go now.

@jackh726 jackh726 merged commit 26fe3f9 into rust-lang:master May 9, 2020
@AzureMarker AzureMarker mentioned this pull request May 18, 2020
Closed
@nathanwhit nathanwhit deleted the typename-slice branch May 25, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extend TypeName with slice type
2 participants
@nathanwhit @jackh726