Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Potentially incomplete links" found by book link checker #425

Closed
AzureMarker opened this issue Apr 30, 2020 · 5 comments · Fixed by #450
Closed

"Potentially incomplete links" found by book link checker #425

AzureMarker opened this issue Apr 30, 2020 · 5 comments · Fixed by #450
Assignees
Labels
good first issue A good issue to start working on Chalk with

Comments

@AzureMarker
Copy link
Member

AzureMarker commented Apr 30, 2020

The link checker currently reports some warnings:

warning: Potential incomplete link

   ┌── what_is_chalk.md:5:18 ───
   │
 5 │ > [open an issue][rustc-issues] so we can fix it. If you are able to fix the
   │                  ^^^^^^^^^^^^^^ Did you forget to define a URL for `rustc-issues`?
   │
   = hint: declare the link's URL. For example: `[rustc-issues]: http://example.com/`

Source: https://github.com/rust-lang/chalk/pull/424/checks?check_run_id=634114550#step:5:16

Rendered example of a broken link:
Screenshot from 2020-04-30 13-49-24

Should these warnings be increased to errors? All of the warnings currently correspond to broken links (2 in total, but the lint checker outputs duplicate warnings).

This issue has been assigned to @Mcat12 via this comment.

@AzureMarker
Copy link
Member Author

The broken links have been fixed, so the remaining issue is if similar future warnings should instead be errors.

@jackh726
Copy link
Member

I would be okay if the warnings got bumped up to errors, since the link check is a separate check and isn't run on master. @Mcat12 do you want to do change this?

@jackh726 jackh726 added the good first issue A good issue to start working on Chalk with label May 11, 2020
@AzureMarker

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2020

Error: Parsing assign command in comment failed: ...'bot assign' | error: specify user to assign to at >| ''...

Please let @rust-lang/release know if you're having trouble with this bot.

@AzureMarker
Copy link
Member Author

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good issue to start working on Chalk with
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants