-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 1.0.80 #834
Conversation
I've spotted few inaccuracies in project's README. Consider #835 prior the version bump:-) |
Hey there, sorry to jump in, Would you please reconsider the changes that introduced For downstream users who have a larger number of third-party dependencies, managing all of the various windows ecosystem versions can be complicated. My fear is that this change will only make the situation worse by adding the dependency to one of the most commonly used crates for Rust, and bloating lockfiles further. Additionally, the current Finally, even though I didn't explicitly test it, I expect this to hamper times more since it will require two compilations of |
Yeah, I guess that's fair. I guess we could use the windows-sys bindings generator. Given how much effort the old version went through to keep the dependency profile light (for this reason), it's probably worth keeping that in mind... I won't have time to work on this for a week or two, but I guess I'd take a patch in the mean time. |
I meant the |
Thanks, I would have a look at it. |
Riddle is the new tool that will replace |
Addressed by #837. |
@complexspaces I've "vendored" windows-sys in #837, could you test the compile-time again please and check if there's still a regression? |
@NobodyXu I gave the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have an actual release with #840 merged?
Yeah. I think I can actually do the release, I just need someone to approve this PR and #840 (due to the branch protection I can't merge without it). |
Thanks! I'll cut the release after work today. |
There have been a lot of changes, so I think it's worth getting a release out