Add Build::asm_flag
#752
Merged
Add Build::asm_flag
#752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcc
approved these changes
Nov 17, 2022
src/lib.rs
Outdated
| fn is_asm(file: &Path) -> bool { | ||
| if let Some(ext) = file.extension() { | ||
| let ext = ext.to_ascii_lowercase(); | ||
| ext == "asm" || ext == "s" |
There was a problem hiding this comment.
This probably will need some adjustment over time, but I don't see anything it's concretely missing now.
|
Ah, there's no to_ascii_lowercase on OsStr back then, that will need to be fixed. |
nicholasbishop
force-pushed
the
bishop-asm-flags
branch
from
ec19756 to
15f4444
Compare
The method allows flags to be specified that are only applied to assembly input files, not C files. This is helpful with clang, which only accepts certain assembly options if the input file is asm, not C.
nicholasbishop
force-pushed
the
bishop-asm-flags
branch
from
15f4444 to
b377da7
Compare
|
I changed the test to disable it if the |
|
Yeah that's fine. |
|
I'll try to cut a release with this and some other changes this weekend. (CC @Mark-Simulacrum) |
|
Great, thanks for the quick review :) |
|
This is in 1.0.77. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method allows flags to be specified that are only applied to assembly input files, not C files. This is helpful with clang, which only accepts certain assembly options if the input file is asm, not C.
Closes #751