Prefer -ar to -gcc-ar
#741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As observed in cross-rs/cross#1100, in some situations `*-gcc-ar` might actually be just broken. I believe this is most likely just a plain bug in gcc (failing to consider `--disable-lto` configuration option somewhere in their build setup,) but for the time being `*-ar` tends to avoid this problem altogether. Code added in rust-lang#736 appears to be preferring `*-gcc-ar`, but no strong rationale is given to prefer one over the other. `*-gcc-ar` being outright broken sometimes seems like a rationale strong enough to continue preferring binutils’ `ar`.
jonhoo
approved these changes
Oct 31, 2022
jonhoo
pushed a commit
to jonhoo/openssl-src-rs
that referenced
this pull request
Oct 31, 2022
Sometimes `gcc-ar` is broken, so when both are available we should prefer non-gcc-ar. See also rust-lang/cc-rs#741.
|
I've also updated alexcrichton/openssl-src-rs#164 to have the updated preference. |
|
I'll get this in a release this weekend (hopefully sooner), sorry for the issues. |
|
What's the status on getting this released? |
|
Very soon. Release notes might be delayed a little but should be published within the next day, probably (still not automated and for various reasons is a multi-person ordeal) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed in cross-rs/cross#1100, in some situations
*-gcc-armight actually be just broken.I believe this is most likely just a plain bug in gcc (failing to consider
--disable-ltoconfiguration option somewhere in their build setup,) but for the time being*-artends to avoid this problem altogether.Code added in #736 appears to be preferring
*-gcc-ar, but no strong rationale is given to prefer one over the other.*-gcc-arbeing outright broken sometimes seems like a rationale strong enough to continue preferring binutils’ar.