Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unsoundness in StderrForwarder::forward_available #1203

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Sep 7, 2024

Fixed #1200

@NobodyXu NobodyXu requested a review from thomcc September 7, 2024 06:04
@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Sep 7, 2024

cc @burakemir @Manishearth I've fixed the unsoundness and removed the use of unsafe in StderrForwarder::forward_available, can you have a look please?

@NobodyXu NobodyXu changed the title Fixed unsoundness in StderrForwarder.forward_available Fixed unsoundness in StderrForwarder::forward_available Sep 7, 2024
@NobodyXu NobodyXu merged commit 5e161c6 into main Sep 7, 2024
52 checks passed
@NobodyXu NobodyXu deleted the NobodyXu-patch-1 branch September 7, 2024 07:40
@github-actions github-actions bot mentioned this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsoundness in command_helpers.rs
2 participants