Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msrv to 1.67 #1143

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Bump msrv to 1.67 #1143

merged 1 commit into from
Jul 8, 2024

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Jul 8, 2024

For #1137

For #1137

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu merged commit 5a1efa2 into main Jul 8, 2024
50 checks passed
@NobodyXu NobodyXu deleted the bump-msrv branch July 8, 2024 11:27
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
@TheBlueMatt
Copy link
Contributor

Does this crate have a documented MSRV policy anywhere? It seems strange to me to bump to 1.67 (breaking any crates which support building on Debian) in a patch version in such a core ecosystem crate.

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Jul 8, 2024

We are discussing this on zulip https://rust-lang.zulipchat.com/#narrow/stream/351149-t-libs.2Fcrates/topic/cc-rs.20MSRV.20policy

We'd like to hear from others, on their expected MSRV requirements for cc

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Jul 8, 2024

(breaking any crates which support building on Debian)

It seems that Debian already vendors the cc crate, they have an old version of cc

https://packages.debian.org/stable/rust/librust-cc+jobserver-dev

@TheBlueMatt
Copy link
Contributor

It seems that Debian already vendors the cc crate, they have an old version of cc

This is unrelated to people building crates on Debian using cargo. For those who want x-lang LTO or to use a toolchain that is built on the same machines as the rest of their host crates pulled by cargo need to support 1.63.

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Jul 8, 2024

For those who want x-lang LTO or to use a toolchain that is built on the same machines as the rest of their host crates pulled by cargo need to support 1.63.

Thanks, that's a scenario I didn't consider.

Is it possible to pin the cc version via Cargo.lock?

@TheBlueMatt
Copy link
Contributor

Ah, I'd already responded at #1144 (comment) we can continue there to keep things in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants