Fix invalid wasi targets compatibility #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
reviewed
Jun 24, 2024
Comment on lines
+3925
to
+3932
| const TARGETS: [&'static str; 5] = [ | ||
| "wasm32-wasi", | ||
| "wasm32-wasip1", | ||
| "wasm32-wasip1-threads", | ||
| "wasm32-wasip2", | ||
| "wasm32-wasi-threads", | ||
| ]; | ||
| return TARGETS.contains(&target); |
There was a problem hiding this comment.
Why are we listing each target? Would target.contains("wasi") not be more forwards-compatible?
There was a problem hiding this comment.
Maybe, it was mostly to ensure if they had a target supporting exceptions or something like that to handle them separately, but maybe its overkill
Yes, I will look into it |
This was referenced Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your help following Fix WASI compilation for C++, I have tested it on my side from main and spotted some issues with incompatible targets, took some time to clean this aswell and ensure every targets are clearly defined to avoid potential issues with no-exceptions flags