Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include aliases with other commands #9764

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Include aliases with other commands #9764

merged 1 commit into from
Aug 9, 2021

Conversation

djmitche
Copy link
Contributor

@djmitche djmitche commented Aug 5, 2021

The principal result is that they are now automatically included in the
cargo --list output. Fixes #8486.

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 5, 2021
@djmitche
Copy link
Contributor Author

djmitche commented Aug 7, 2021

OMG, green on the first try! ❤️ rust :)

@nipunn1313
Copy link
Contributor

Would be good to add a test (would also make it easy to see what the output looks like in the review).

There's a test in cargo_command.rs called list_aliases_with_descriptions which could be a good starting point.
To add a new user-command on the path - there's an example which does so in list_command_looks_at_path also in cargo_command.rs

@djmitche
Include aliases with other commands
1c5e68b 
The principal result is that they are now automatically included in the
`cargo --list` output.  Fixes rust-lang#8486.
nipunn1313
nipunn1313 reviewed Aug 7, 2021
View reviewed changes
Copy link
Contributor

@nipunn1313 nipunn1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I'm not a maintainer, so I don't have authority to merge, but I took a look and it lgtm!

tests/testsuite/cargo_command.rs
.with_stdout_contains(" myaliasvec foo --bar")
.run();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Lgtm!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! On projects where I am a maintainer I really appreciate other contributors looking at PRs, and I bet the cargo maintainers do too.

@alexcrichton
Copy link
Member

Looks great to me as well, thanks @djmitche!

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 9, 2021

📌 Commit 1c5e68b has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2021
@bors
Copy link
Collaborator

bors commented Aug 9, 2021

⌛ Testing commit 1c5e68b with merge 0a2581d...

@bors
Copy link
Collaborator

bors commented Aug 9, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing 0a2581d to master...

@bors bors merged commit 0a2581d into rust-lang:master Aug 9, 2021
@bors bors mentioned this pull request Aug 9, 2021
Merged
@ehuss ehuss mentioned this pull request Aug 10, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 11, 2021
@JohnTitor
Rollup merge of rust-lang#87928 - ehuss:update-cargo, r=ehuss
ec47f6e 
Update cargo

9 commits in cc17afbb0067b1f57d8882640f63b2168d5b7624..b51439fd8b505d4800a257acfecf3c69f81e35cf
2021-08-02 20:28:08 +0000 to 2021-08-09 18:40:05 +0000
- Deduplicate entries in cargo --list (rust-lang/cargo#9773)
- Include aliases with other commands (rust-lang/cargo#9764)
- Add a profile option to select the codegen backend (rust-lang/cargo#9118)
- remove useless conversions (rust-lang/cargo#9617)
- collapse nested if blocks (rust-lang/cargo#9613)
- Refactor fake_file() away from cargo_command tests (rust-lang/cargo#9767)
- Update cargo-platform to 0.1.2 (rust-lang/cargo#9762)
- Bump to the latest jobserver dependency (rust-lang/cargo#9760)
- Fix semver check for rust 1.54.0 (rust-lang/cargo#9763)
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 11, 2021
@JohnTitor
Rollup merge of rust-lang#87928 - ehuss:update-cargo, r=ehuss
dd6ff48 
Update cargo

9 commits in cc17afbb0067b1f57d8882640f63b2168d5b7624..b51439fd8b505d4800a257acfecf3c69f81e35cf
2021-08-02 20:28:08 +0000 to 2021-08-09 18:40:05 +0000
- Deduplicate entries in cargo --list (rust-lang/cargo#9773)
- Include aliases with other commands (rust-lang/cargo#9764)
- Add a profile option to select the codegen backend (rust-lang/cargo#9118)
- remove useless conversions (rust-lang/cargo#9617)
- collapse nested if blocks (rust-lang/cargo#9613)
- Refactor fake_file() away from cargo_command tests (rust-lang/cargo#9767)
- Update cargo-platform to 0.1.2 (rust-lang/cargo#9762)
- Bump to the latest jobserver dependency (rust-lang/cargo#9760)
- Fix semver check for rust 1.54.0 (rust-lang/cargo#9763)
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 12, 2021
@JohnTitor
Rollup merge of rust-lang#87928 - ehuss:update-cargo, r=ehuss
12117e3 
Update cargo

9 commits in cc17afbb0067b1f57d8882640f63b2168d5b7624..b51439fd8b505d4800a257acfecf3c69f81e35cf
2021-08-02 20:28:08 +0000 to 2021-08-09 18:40:05 +0000
- Deduplicate entries in cargo --list (rust-lang/cargo#9773)
- Include aliases with other commands (rust-lang/cargo#9764)
- Add a profile option to select the codegen backend (rust-lang/cargo#9118)
- remove useless conversions (rust-lang/cargo#9617)
- collapse nested if blocks (rust-lang/cargo#9613)
- Refactor fake_file() away from cargo_command tests (rust-lang/cargo#9767)
- Update cargo-platform to 0.1.2 (rust-lang/cargo#9762)
- Bump to the latest jobserver dependency (rust-lang/cargo#9760)
- Fix semver check for rust 1.54.0 (rust-lang/cargo#9763)
@ehuss ehuss added this to the 1.56.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nipunn1313 nipunn1313 nipunn1313 left review comments

Assignees

@Eh2406 Eh2406

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

display aliases in cargo --list
7 participants
@djmitche @rust-highfive @nipunn1313 @alexcrichton @bors @ehuss @Eh2406