Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated default rust edition documentation #8952

Closed
wants to merge 1 commit into from
Closed

Fix outdated default rust edition documentation #8952

wants to merge 1 commit into from

Conversation

hkennyv
Copy link
Contributor

@hkennyv hkennyv commented Dec 6, 2020

fixes #8951

this is my first PR to cargo, so please LMK if there's anything else I need to do :)

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2020
@ehuss
Copy link
Contributor

ehuss commented Dec 6, 2020

The default if not specified is 2015. The default for cargo new is the latest edition (2018), it will explicitly place edition = "2018" in the manifest to override that default. But this documentation is for how the manifest itself interprets the field.

@hkennyv
Copy link
Contributor Author

hkennyv commented Dec 6, 2020

Ahh I see, thanks for the clarification @ehuss. I was confusing this with the default for cargo new!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated documentation for manifest edition field
4 participants