Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add actionable help message for --features #8773

Merged
merged 5 commits into from
Oct 14, 2020
Merged

Add actionable help message for --features #8773

merged 5 commits into from
Oct 14, 2020

Conversation

pickfire
Copy link
Contributor

Fix #8770

@rust-highfive
Copy link

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2020
ehuss
ehuss reviewed Oct 14, 2020
View reviewed changes
tests/testsuite/package_features.rs Outdated Show resolved Hide resolved
src/cargo/util/command_prelude.rs Outdated Show resolved Hide resolved
@pickfire
Copy link
Contributor Author

@ehuss By the way, how should I bold thehelp and note? Note is bold and help in cyan in the rustc but not here, it's just plain text here.

@ehuss
Copy link
Contributor

ehuss commented Oct 14, 2020

Thanks!

@bors r+

how should I bold thehelp and note?

Cargo's messages don't have much structure, so it isn't really possible right now.

@bors
Copy link
Collaborator

bors commented Oct 14, 2020

📌 Commit fd5902c has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2020
@bors
Copy link
Collaborator

bors commented Oct 14, 2020

⌛ Testing commit fd5902c with merge 655e122...

@bors
Copy link
Collaborator

bors commented Oct 14, 2020

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 655e122 to master...

@bors bors merged commit 655e122 into rust-lang:master Oct 14, 2020
@ehuss ehuss mentioned this pull request Oct 14, 2020
Merged
@pickfire pickfire deleted the patch-1 branch October 15, 2020 03:29
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2020
@bors
Auto merge of rust-lang#77952 - ehuss:update-cargo, r=ehuss
7f58716 
Update cargo

11 commits in 9d1a4863abd9237dbf9d1b74c78632b6a205f6bb..12db56cdedbc2c26a9aa18f994c0188cdcc67df5
2020-10-05 18:29:52 +0000 to 2020-10-14 23:07:45 +0000
- Reinstate CARGO_PRIMARY_PACKAGE (take 2) (rust-lang/cargo#8758)
- Add actionable help message for --features (rust-lang/cargo#8773)
- Fix panic in `cargo doc` with -Zfeatures=itarget (rust-lang/cargo#8777)
- Update git2. (rust-lang/cargo#8778)
- Document RUSTFMT environment variable (rust-lang/cargo#8767)
- Update crossbeam-utils requirement from 0.7 to 0.8 (rust-lang/cargo#8769)
- Update toml dependency (rust-lang/cargo#8772)
- Mark proc-macro crates (rust-lang/cargo#8765)
- cargo-tree: mention special target `all` in CLI help text (rust-lang/cargo#8766)
- Bump to 0.50.0, update changelog (rust-lang/cargo#8764)
- Update deprecated GitHub add-path in workflows. (rust-lang/cargo#8760)
@ehuss ehuss added this to the 1.49.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

--features in workspace note not actionable
4 participants
@pickfire @rust-highfive @ehuss @bors