Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow -Zconfig-profile for rust 1.43.0 #8030

Closed
wants to merge 1 commit into from

Conversation

Keruspe
Copy link
Contributor

@Keruspe Keruspe commented Mar 23, 2020

While -Zconfig-profile doesn't do anything since the stabilisation of this feature, rust 1.43.0 still passes this to cargo, so allow (but ignore) it to allow rust 1.43.0 to build itself.

Fixes rust-lang/rust#69975 once cargo gets updated in the beta branch

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.43.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2020
While -Zconfig-profile doesn't do anything since the stabilisation of this feature,
rust 1.43.0 still passes this to cargo, so allow (but ignore) it to allow rust 1.43.0
to build itself

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
@Keruspe Keruspe force-pushed the config-profile-1.43.0 branch from 0798647 to 03b0bdb Compare March 23, 2020 09:26
@aleksator
Copy link
Contributor

Isn't it backwards? I'd think that since the flag was stabilized, a PR to rustc should be opened instead to stop sending this flag.

@Keruspe
Copy link
Contributor Author

Keruspe commented Mar 23, 2020

@aleksator rustbuild from rust 1.43.0 still needs to pass this flag when building from 1.42.0 (which it does, by default). The goal here is just not to refuse the flag, only for this release, to enable a smooth transition and be able to also build rust 1.43.0 using itself, which is something distribution packages usually do.

The alternative is to conditionally drop the argument in rustbuild in downstream packages, which can be done if preferred. We just usually submit what we believe to be an acceptable solution upstream first

@Mark-Simulacrum
Copy link
Member

We definitely shouldn't be filing this against Cargo, regardless -- if you want to file a patch against rust-lang beta branch then I can review that there (we already do some version detection on the bootstrap compiler, IIRC, so if this can fit into that I wouldn't be opposed to it). Otherwise, yeah, I would fix downstream.

@Keruspe
Copy link
Contributor Author

Keruspe commented Mar 23, 2020

Ok, closing this one then, will try to do this in rustbuild

@Keruspe Keruspe closed this Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants