Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dep_targets. #7626

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Remove dep_targets. #7626

merged 1 commit into from
Nov 26, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 23, 2019

This is just some code cleanup. The dep_targets method has been replaced by unit_deps, which doesn't force the creation of a new Vec.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2019
@bors
Copy link
Contributor

bors commented Nov 23, 2019

☔ The latest upstream changes (presumably #7625) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss ehuss force-pushed the remove-dep-targets branch from 060b978 to cc9f5a8 Compare November 23, 2019 23:39
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 25, 2019

📌 Commit cc9f5a8 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2019
@bors
Copy link
Contributor

bors commented Nov 25, 2019

⌛ Testing commit cc9f5a8 with merge 9621e3b06e809bf5ac27fb86722bf58c256ae05b...

@bors
Copy link
Contributor

bors commented Nov 25, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2019
@ehuss
Copy link
Contributor Author

ehuss commented Nov 26, 2019

@bors retry
(needed to run after broken plugin tests were removed)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2019
@bors
Copy link
Contributor

bors commented Nov 26, 2019

⌛ Testing commit cc9f5a8 with merge 14654f3...

bors added a commit that referenced this pull request Nov 26, 2019
Remove dep_targets.

This is just some code cleanup.  The `dep_targets` method has been replaced by `unit_deps`, which doesn't force the creation of a new Vec.
@bors
Copy link
Contributor

bors commented Nov 26, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 14654f3 to master...

@bors bors merged commit cc9f5a8 into rust-lang:master Nov 26, 2019
bors added a commit to rust-lang/rust that referenced this pull request Dec 4, 2019
Update cargo

11 commits in 750cb1482e4d0e74822cded7ab8b3c677ed8b041..626f0f40efd32e6b3dbade50cd53fdfaa08446ba
2019-11-23 23:06:36 +0000 to 2019-12-03 16:53:04 +0000
- Change some texts to links in README (rust-lang/cargo#7652)
- Update config and environment variable docs. (rust-lang/cargo#7650)
- Stop ignoring .rs.bk files; rustfmt hasn't generated them in years (rust-lang/cargo#7647)
- Various contributing docs updates. (rust-lang/cargo#7642)
- Stabilize profile-overrides. (rust-lang/cargo#7591)
- Update comment about ResolveVersion default version. (rust-lang/cargo#7637)
- Update tests for slight wording change in rustdoc error message. (rust-lang/cargo#7641)
- Remove dep_targets. (rust-lang/cargo#7626)
- vendor: don't use canonical path in .cargo/config (rust-lang/cargo#7629)
- Minor testsuite organization. (rust-lang/cargo#7628)
- Remove failing plugin tests. (rust-lang/cargo#7630)
@ehuss ehuss added this to the 1.41.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants