Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo vendor: Don't delete hidden top-level files. #7242

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Aug 13, 2019

cargo vendor (without --no-delete) will delete all files in the vendor/ directory when it starts. This changes it so that it will skip any entries starting with a dot. This allows one to track the vendor directory with a source control system like git.

Closes #7109

(Note: two commits, one is a test change.)

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 13, 2019

📌 Commit 492abb3 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2019
@bors
Copy link
Collaborator

bors commented Aug 13, 2019

⌛ Testing commit 492abb3 with merge 628710e1b668e5dd9399633c443f99127b1a0f7e...

@bors
Copy link
Collaborator

bors commented Aug 13, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2019
@ehuss
Copy link
Contributor Author

ehuss commented Aug 13, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2019
@bors
Copy link
Collaborator

bors commented Aug 13, 2019

⌛ Testing commit 492abb3 with merge c34d27b60a396ff6368d78f6fe2955f6e314b76d...

@bors
Copy link
Collaborator

bors commented Aug 13, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2019
@ehuss
Copy link
Contributor Author

ehuss commented Aug 13, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2019
@bors
Copy link
Collaborator

bors commented Aug 13, 2019

⌛ Testing commit 492abb3 with merge 85a52ce...

bors added a commit that referenced this pull request Aug 13, 2019
 `cargo vendor`: Don't delete hidden top-level files.

`cargo vendor` (without `--no-delete`) will delete all files in the `vendor/` directory when it starts. This changes it so that it will skip any entries starting with a dot. This allows one to track the vendor directory with a source control system like git.

Closes #7109

(Note: two commits, one is a test change.)
@bors
Copy link
Collaborator

bors commented Aug 13, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 85a52ce to master...

@bors bors merged commit 492abb3 into rust-lang:master Aug 13, 2019
@ehuss ehuss added this to the 1.39.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo vendor purges the vendor directory, including its .git
4 participants