Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates to bash completion. #6644

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Feb 7, 2019

  • Be smarter about editing an existing command (currently completion only worked well at the end of the line).
  • Update for new command line options and commands.
  • Support libtest completions.
  • Fallback to filename completion in some circumstances.
  • Use rustup to complete --target.

@rust-highfive
Copy link

r? @dwijnand

(rust_highfive has picked a reviewer for you, use r? to override)

@dwijnand
Copy link
Member

dwijnand commented Feb 7, 2019

LGTM. I think this solves some tickets too.

@alexcrichton
Copy link
Member

@bors: r=dwijnand

@bors
Copy link
Collaborator

bors commented Feb 8, 2019

📌 Commit 5773aaa has been approved by dwijnand

@bors
Copy link
Collaborator

bors commented Feb 8, 2019

⌛ Testing commit 5773aaa with merge 1b17388...

bors added a commit that referenced this pull request Feb 8, 2019
Some updates to bash completion.

- Be smarter about editing an existing command (currently completion only worked well at the end of the line).
- Update for new command line options and commands.
- Support libtest completions.
- Fallback to filename completion in some circumstances.
- Use rustup to complete `--target`.
@bors
Copy link
Collaborator

bors commented Feb 8, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: dwijnand
Pushing 1b17388 to master...

@bors bors merged commit 5773aaa into rust-lang:master Feb 8, 2019
bors added a commit to rust-lang/rust that referenced this pull request Feb 10, 2019
Bump cargo to 865cb70

Merged PRs:

* Replace util::without_prefix with Path::strip_prefix rust-lang/cargo#6620
* keep track of crates that are whitelisted to be used even if yanked rust-lang/cargo#6611
* Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. rust-lang/cargo#6625
* Bail when trying to run "test --doc --no-run" rust-lang/cargo#6628
* In cargo test's help, add that examples are built rust-lang/cargo#6619
* Extract & re-use filter_targets in cargo_compile rust-lang/cargo#6621
* Test cleanup: remove unnecessary with_status(0) rust-lang/cargo#6630
* Fix run's help message rust-lang/cargo#6631
* Some updates to bash completion. rust-lang/cargo#6644
* Introduce Source::download_now rust-lang/cargo#6637
* Switch from unused_imports to deprecated to test unfixable warnings rust-lang/cargo#6649
bors added a commit to rust-lang/rust that referenced this pull request Feb 11, 2019
Bump cargo to 865cb70

Merged PRs:

* Replace util::without_prefix with Path::strip_prefix rust-lang/cargo#6620
* keep track of crates that are whitelisted to be used even if yanked rust-lang/cargo#6611
* Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. rust-lang/cargo#6625
* Bail when trying to run "test --doc --no-run" rust-lang/cargo#6628
* In cargo test's help, add that examples are built rust-lang/cargo#6619
* Extract & re-use filter_targets in cargo_compile rust-lang/cargo#6621
* Test cleanup: remove unnecessary with_status(0) rust-lang/cargo#6630
* Fix run's help message rust-lang/cargo#6631
* Some updates to bash completion. rust-lang/cargo#6644
* Introduce Source::download_now rust-lang/cargo#6637
* Switch from unused_imports to deprecated to test unfixable warnings rust-lang/cargo#6649
@ehuss ehuss added this to the 1.34.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants