Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support untyped warnings from registries with successful publish #6303

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Support untyped warnings from registries with successful publish #6303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/cargo/ops/registry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,12 @@ fn transmit(
config.shell().warn(&msg)?;
}

if !warnings.other.is_empty() {
for msg in warnings.other {
config.shell().warn(&msg)?;
}
}

Ok(())
}
Err(e) => Err(e),
Expand Down
9 changes: 9 additions & 0 deletions src/crates-io/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ pub struct User {
pub struct Warnings {
pub invalid_categories: Vec<String>,
pub invalid_badges: Vec<String>,
pub other: Vec<String>,
}

#[derive(Deserialize)]
Expand Down Expand Up @@ -223,9 +224,17 @@ impl Registry {
.map(|x| x.iter().flat_map(|j| j.as_str()).map(Into::into).collect())
.unwrap_or_else(Vec::new);

let other: Vec<String> = response
.get("warnings")
.and_then(|j| j.get("other"))
.and_then(|j| j.as_array())
.map(|x| x.iter().flat_map(|j| j.as_str()).map(Into::into).collect())
.unwrap_or_else(Vec::new);

Ok(Warnings {
invalid_categories,
invalid_badges,
other,
})
}

Expand Down