Treat "proc-macro" crate type the same as proc-macro = true
#6256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change if you say: crate-type = ["proc-macro"]
plugin = trueFound this in the https://crates.io/crates/arthas_derive package. Do you think it is worth detecting this scenario and allowing it with a warning? |
ehuss
force-pushed
the
proc-macro-crate-type
branch
from
5b8301c
to
f867f45
Compare
|
Nice catch on that regression, yeah let's emit a warning for now for that. Additionally, could a warning be printed to say that |
ehuss
force-pushed
the
proc-macro-crate-type
branch
from
f867f45
to
b0e767f
Compare
|
Added some warnings. I also added a check for multiple crate-types, just to assert an assumption, but maybe that's not necessary (rustc has the same check). |
|
@bors: r+ |
|
📌 Commit b0e767f has been approved by |
bors
added a commit
that referenced
this pull request
Nov 6, 2018
Treat "proc-macro" crate type the same as `proc-macro = true` Effectively closes #5310 since they are now identical.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively closes #5310 since they are now identical.