Introduce the CWD macro in test output asserting #5950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Nice! r=me with green tests! (looks like some linux failures?) @bors: delegate+ As an aside I wish we could give you like a flaming avatar to represent how you're basically on fire with changes right now! |
|
✌️ @dwijnand can now approve this pull request |
|
Yep, I'll get the tests passing. Btw, the avatar is small, but this is kind of satisfying to see: |
dwijnand
force-pushed
the
cwd
branch
6 times, most recently
from
5f6666e to
c5743b4
Compare
Avoids dealing with things like CWD changing.
|
Finally ✅! and therefore.. (😁) @bors: r=alexcrichton |
|
📌 Commit d5fc8dc has been approved by |
bors
added a commit
that referenced
this pull request
Aug 30, 2018
Introduce the CWD macro in test output asserting Avoids dealing with things like CWD changing. Mentioned in #5742
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids dealing with things like CWD changing.
Mentioned in #5742