Add --allow-staged to cargo fix
#5943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Justen <jljusten@gmail.com>
This change splits out staged changes from dirty changes, and lets the user know if they should consider using the --allow-staged flag. Signed-off-by: Jordan Justen <jljusten@gmail.com>
Signed-off-by: Jordan Justen <jljusten@gmail.com>
* master: (25 commits) Migrate from tests fom assert_that/execs to .run() Wrap ProcessBuilder in Execs & make .cargo return that Make old Execs methods take not consume self Extract Execs::match_process Add #[must_use] to Execs Inline Execs::_with_stderr Remove an unrun "cargo build" ProcessBuilder Add documentation for creating test dependencies. Only use non-absolute paths for `path` dependencies Fix test failure on nightly due to `codemap::Span` change. New metabuild strategy using custom src_path enum. Remove unnecessary change. Address review comments. Metabuild (RFC 2196) Handle Window's missing file error message Make "cargo uninstall" uninstall the cwd bins update comment based on further research List URL in HTTP download failures Fix compilation error Improve the `cargo install` deprecation messaging ...
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
Got what looks like a spurious error on Travis CI (only): Close/reopen CI validation restart game. |
|
😕 test |
|
@bors: r+ Nice! |
|
📌 Commit 8c2d0df has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5737
This is @jljusten's branch, adapted to the testsuite changes in master.
Submitted as an alternative to #5910 to expedite #5737 resolution in time for Edition RC 1.