Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the cargo install deprecation messaging #5925

Merged
merged 2 commits into from
Aug 22, 2018

Conversation

dwijnand
Copy link
Member

Fixes #5917

r? @matklad
/cc @brson also as I'd love to hear your feedback too.

Apparently the bail! macro doesn't support trailing commas :-/
@alexcrichton
Copy link
Member

@bors: r+

Looks great to me, thanks!

@bors
Copy link
Contributor

bors commented Aug 22, 2018

📌 Commit 3e6de57 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Aug 22, 2018

⌛ Testing commit 3e6de57 with merge 3bc5260...

bors added a commit that referenced this pull request Aug 22, 2018
…xcrichton

Improve the `cargo install` deprecation messaging

Fixes #5917

r? @matklad
/cc @brson also as I'd love to hear your feedback too.
@dwijnand
Copy link
Member Author

Awesome.

@bors
Copy link
Contributor

bors commented Aug 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 3bc5260 to master...

@bors bors merged commit 3e6de57 into rust-lang:master Aug 22, 2018
@dwijnand dwijnand deleted the improve-install-cwd-deprecation branch August 22, 2018 18:13
@brson
Copy link
Contributor

brson commented Aug 22, 2018

It's clearer now. Thanks @dwijnand .

@ehuss ehuss added this to the 1.30.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing cargo install warning
6 participants