run some tests with minimal-versions on CI

[Eh2406]

In #5757 we discovered that sum test don't pass with minimal-versions, and so only added CI for cargo check. This PR is to see if that is still needed, and if it is then which test rely on upstream bugfix.

[rust-highfive]

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

[dwijnand]

LGTM, if it passes 😄

[Eh2406]

Travis:

failures:
    rustc_info_cache::rustc_info_cache
    shell_quoting::features_are_quoted

[alexcrichton]

Thanks! I think we can probably afford to do this on Travis, but I don't think we have enough capacity to do this on AppVeyor :(

(we're already getting pretty backed up by just adding check run)

[Eh2406]

I got features_are_quoted working. But I have no idea what dep is preventing rustc_info_cache. @matklad you wrote that test, do you have a gess?

[matklad]

I have a guess!

Rustc cache works by saving a Serialize POD struct in a file and then reading it back. Once of the fields in the struct is u64. Judging by the error message, looks like it was saved as string, and can't be read back as u64.

I guess that serde_json changed serialization of long integers some time in the past: you can't save integers with more than 53 as ints, b/c JavaScript does not have integers, and that explains where the strings might come from.

I've done zero real investigation though, but let's try to pin-up serde-[json] version?

[Eh2406]

Now appear is complaining

failures:
build_script::custom_build_env_var_rustc_linker

But I will not be able too work on OSS stuff for the next week.

[Eh2406]

Back and rebased. This time it is:

appveyor:

• build_script::custom_build_env_var_rustc_linker

travis:

• check::short_message_format

Ideays?

[ehuss]

The short_message_format test should probably check if !is_nightly() (see doc::short_message_format for the exact same reason). 1.27 does not support the short message format.

custom_build_env_var_rustc_linker only works if there is a cross-compile target to test against. Either you can set the CFG_DISABLE_CROSS_TESTS environment variable to disable cross tests when on stable, or install an alternate stable toolchain. For example, this is where it installs the alternate toolchain for nightly:

cargo/appveyor.yml

Line 16 in 6a7672e

- rustup target add %OTHER_TARGET%

[dwijnand]

The short_message_format test should probably check if !is_nightly() (see doc::short_message_format for the exact same reason). 1.27 does not support the short message format.

1.28 does (rust-lang/rust#49546). Shouldn't that CI setup be upgrade to Rust 1.28 instead?

[dwijnand]

The message here is wrong. This relies on rustc --error-format which is stable as of 1.28, but we're (currently) using 1.27.2.

I propose we upgrade to that CI setup to 1.28 and remove this guard.

[Eh2406]

Done. Can we also remove this from doc::short_message_format?

[dwijnand]

That one not till 1.30.

[dwijnand]

In other news, this went ✅❗️❗️

[alexcrichton]

With green tests, this may be good to land? My main concern would be about CI time on AppVeyor (40m minimum) which is a bit excessive, could we perhaps stick to check on Windows but run the tests on Travis? Or were Windows-specific runtime bugs found here?

[Eh2406]

I am just commiting a back out on AppVeyor.

The inspiration for doing this work was all the libgit2 windows bugs around / vs \. Each PR came with a bump in the toml, but only because we were vigilant not because CI tested it. I.e. you release a bug fix to libgit2 our CI is green as it uses the new version, nothing reminds us that we need to bump.

[alexcrichton]

Gah bummer :(

We can try to be vigilant about those sorts of fixes for now, and otherwise if we feel like we have more appveyor capacity in the future we can always reenable!

@bors: r+

[bors]

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove [WIP] from this PR's title when it is ready for review.

[Eh2406]

@bors: r=alexcrichton

[bors]

📌 Commit 620d5cc has been approved by alexcrichton

[bors]

⌛ Testing commit 620d5cc with merge a284c3f...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a284c3f to master...