Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply dependency renamings when running rustdoc #5794

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Jul 25, 2018

Fixes #5792

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Thanks @Nemo157!

@bors
Copy link
Contributor

bors commented Jul 25, 2018

📌 Commit a432619 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 26, 2018

⌛ Testing commit a432619 with merge 191bfbf...

bors added a commit that referenced this pull request Jul 26, 2018
Apply dependency renamings when running rustdoc

Fixes #5792
@bors
Copy link
Contributor

bors commented Jul 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 191bfbf to master...

@bors bors merged commit a432619 into rust-lang:master Jul 26, 2018
@Nemo157 Nemo157 deleted the rustdoc-rename-extern branch July 26, 2018 09:13
@ehuss ehuss added this to the 1.29.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renamed dependencies don't appear to be available when compiling doc-tests
6 participants