Copy --all-features request to all workspace members
#5556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an accidental regression introduced in rust-lang#5012 where the `--all-features` CLI flag was only propagated to the "main crate" as opposed to all workspace packages. This behavior has [already been deemed][pr] as "basically not what you want", but for now it's best to avoid the regression. Closes rust-lang#5518 [pr]: rust-lang#5353
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
r=me. #5012 is in beta, but not in stable, right? Than we should beta-backport? |
|
I believe so! @bors: r+ |
|
📌 Commit a70d519 has been approved by |
|
⌛ Testing commit a70d519 with merge 4138e50bec8b7895993d7d29397e642b0fc1dc26... |
|
er, @bors: r=matklad |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit a70d519 has been approved by |
bors
added a commit
that referenced
this pull request
May 24, 2018
Copy `--all-features` request to all workspace members This fixes an accidental regression introduced in #5012 where the `--all-features` CLI flag was only propagated to the "main crate" as opposed to all workspace packages. This behavior has [already been deemed][pr] as "basically not what you want", but for now it's best to avoid the regression. Closes #5518 [pr]: #5353
|
☀️ Test successful - status-appveyor, status-travis |
bors
added a commit
that referenced
this pull request
May 25, 2018
[beta] Copy `--all-features` request to all workspace members Backport of #5556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an accidental regression introduced in #5012 where the
--all-featuresCLI flag was only propagated to the "main crate" as opposed toall workspace packages. This behavior has already been deemed as
"basically not what you want", but for now it's best to avoid the regression.
Closes #5518