-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy --all-features
request to all workspace members
#5556
Conversation
This fixes an accidental regression introduced in rust-lang#5012 where the `--all-features` CLI flag was only propagated to the "main crate" as opposed to all workspace packages. This behavior has [already been deemed][pr] as "basically not what you want", but for now it's best to avoid the regression. Closes rust-lang#5518 [pr]: rust-lang#5353
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
r=me. #5012 is in beta, but not in stable, right? Than we should beta-backport? |
I believe so! @bors: r+ |
📌 Commit a70d519 has been approved by |
⌛ Testing commit a70d519 with merge 4138e50bec8b7895993d7d29397e642b0fc1dc26... |
er, @bors: r=matklad |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit a70d519 has been approved by |
Copy `--all-features` request to all workspace members This fixes an accidental regression introduced in #5012 where the `--all-features` CLI flag was only propagated to the "main crate" as opposed to all workspace packages. This behavior has [already been deemed][pr] as "basically not what you want", but for now it's best to avoid the regression. Closes #5518 [pr]: #5353
☀️ Test successful - status-appveyor, status-travis |
[beta] Copy `--all-features` request to all workspace members Backport of #5556
This fixes an accidental regression introduced in #5012 where the
--all-features
CLI flag was only propagated to the "main crate" as opposed toall workspace packages. This behavior has already been deemed as
"basically not what you want", but for now it's best to avoid the regression.
Closes #5518