[beta] Fix mode generated in maybe_lib
#5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `mode` for the library dependency is dependent on the library target rather than the target which is the reason for the dependency on the library! Closes rust-lang/rust#50640
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
@bors: r+ |
|
📌 Commit cfeb768 has been approved by |
bors
added a commit
that referenced
this pull request
May 12, 2018
[beta] Fix mode generated in `maybe_lib` Beta backport of #5520
|
☀️ Test successful - status-appveyor, status-travis |
|
@alexcrichton Let me know if you'd like me to post PRs to the rust repo to pick up these changes. Not sure how tedious that is for you, but I'm happy to help. |
|
@ehuss sure yeah if you wanna take care of that feel free! |
ehuss
added a commit
to ehuss/rust
that referenced
this pull request
May 12, 2018
Regression fixes: - rust-lang/cargo#5510 `cargo rustc` broken for tests in project with bins - rust-lang/cargo#5523 (rust-lang#50640) shared proc-macro dependency built incorrectly
bors
added a commit
to rust-lang/rust
that referenced
this pull request
May 13, 2018
[BETA] Update Cargo Regression fixes: - rust-lang/cargo#5510 `cargo rustc` broken for tests in project with bins - rust-lang/cargo#5523 (#50640) shared proc-macro dependency built incorrectly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta backport of #5520