Enable new behavior of --feature
#5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ |
|
📌 Commit 038eec5 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 19, 2018
Enable new behavior of `--feature` So far, the feedback on https://internals.rust-lang.org/t/help-us-test-the-breaking-bug-fix-to-cargo-features/7317 has been positive, so here's a PR to try this in nightly. Note that the logic is slightly tweak for the case `cargo build -p not-a-workspace-member`: we want not only to resolve all ws members in this case, but to enable all of their features as well! As a sanity check, this seems to be forward compatible with further improvements to features: 1) when we solve the grand bug of features being unified across the whole workspace, `cargo build -p not-a-member` would hopefully just work without additional contortions. 2) we might add a way to specify features per package, like `cargo build -p foo -p bar --features "foo/serde bar/serde"`
|
☀️ Test successful - status-appveyor, status-travis |
matklad
added a commit
to matklad/rust
that referenced
this pull request
Apr 21, 2018
Some noteble changes: * regression fix: rust-lang/cargo#5390 * potentially breaking bug-fix: rust-lang/cargo#5389 * Cargo now caches the result of `rustc -vV`. It checks `rustc` binary mtime and rustup toolchain settings, so it should probably "just work" with rustbuild.
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Apr 22, 2018
Update Cargo Some noteble changes: * ~~regression fix: rust-lang/cargo#5390 * ~~potentially breaking bug-fix: rust-lang/cargo#5389 * ~~Cargo now caches the result of `rustc -vV`. It checks `rustc` binary mtime and rustup toolchain settings, so it should probably "just work" with rustbuild.~~ potentially breaking bug-fix: rust-lang/cargo#5390
|
Servo’s build broke, I think because of this, without a prior warning. It’s not clear what the compatibility story is here. |
|
(PR for that Servo build: servo/servo#20703, already including a build system change.) |
|
Let's continue discussion at the tracking issue: #5364 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the feedback on https://internals.rust-lang.org/t/help-us-test-the-breaking-bug-fix-to-cargo-features/7317 has been positive, so here's a PR to try this in nightly.
Note that the logic is slightly tweak for the case
cargo build -p not-a-workspace-member: we want not only to resolve all ws members in this case, but to enable all of their features as well!As a sanity check, this seems to be forward compatible with further improvements to features:
cargo build -p not-a-memberwould hopefully just work without additional contortions.cargo build -p foo -p bar --features "foo/serde bar/serde"