Don't print profiling information twice #5319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's important to `.clear` the messages so that we don't print them again for the next "profiling session". It might be argued that really we should have a single "profiling session" for Cargo, but we don't at the moment. And, while we are at it, let's lock stdout as well, so that we won't get confused when Cargo becomes multi-threaded and prints profiling info from several threads simultaneously.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors delegate=Eh2406 Let's merge this, if it looks reasonable? Should help us to troubleshoot current perf problems a little bit better :-) |
|
✌️ @Eh2406 can now approve this pull request |
|
I have not used cargos built in profiling before, I just run WPA while cargo is running, but it looks good to me. @bors r+ |
|
📌 Commit 1549488 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 8, 2018
Don't print profiling information twice It's important to `.clear` the messages so that we don't print them again for the next "profiling session". It might be argued that really we should have a single "profiling session" for Cargo, but we don't at the moment. And, while we are at it, let's lock stdout as well, so that we won't get confused when Cargo becomes multi-threaded and prints profiling info from several threads simultaneously.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important to
.clearthe messages so that we don't print themagain for the next "profiling session". It might be argued that really
we should have a single "profiling session" for Cargo, but we don't at
the moment.
And, while we are at it, let's lock stdout as well, so that we won't
get confused when Cargo becomes multi-threaded and prints profiling info
from several threads simultaneously.