Upgrade env_logger

[sfackler]

0.4 depends on log 0.3 and so misses out on module names.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[alexcrichton]

We've unfortunately gotten bitten in the past because of prerelease versions. I think Cargo will consider it semver compatible with 0.5.0 for example? (which sometimes has API breaking changes).

@KodrAus out of curiosity, do you know if 0.5.0 will happen soon?

[sfackler]

I can switch it to an equality constraint, but a full 0.5.0 release would be best, yeah.

[alexcrichton]

@KodrAus mentioned that env_logger is close to an 0.5 release (like in the next day or two), so r=me if we hold out for that and then update here.

[sfackler]

👍

[KodrAus]

Thanks @sfackler! Yep, I'm pushing out 0.5 today, just checking the docs now for typos and broken links. There are a few differences between the versions you might be interested in for cargo:

• env_logger now depends on chrono
• env_logger now include a timestamp in the format by default. If this is too noisy we can tweak the format to remove it
• env_logger now writes colours, read from an environment variable by default

I spiked out an upgrade that tried to maintain the cargo command's own colour choice here. If you ignore the fact that it leaks it's a lot of machinery for coloured output, but if folks want coloured logs from cargo using env_logger I think we'll need something like that.

The simpler approach would be something like:

env_logger::Builder::from_env(env_logger::Env::default())
    .write_style(env_logger::WriteStyle::Never)
    .init();

So that we never write coloured logs.

[alexcrichton]

Looks like a new version is out! @sfackler want to update this PR?

[alexcrichton]

Thanks @KodrAus!

[sfackler]

Updated!

[alexcrichton]

@bors: r+

Thanks @sfackler!

[bors]

📌 Commit a540a39 has been approved by alexcrichton

[bors]

⌛ Testing commit a540a39 with merge 3eea5fe827f506931f6303e853219bdd47f6b7b9...

[bors]

💔 Test failed - status-travis

[alexcrichton]

@bors: retry

…

On Wed, Jan 17, 2018 at 12:38 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/cargo/builds/329986072?utm_source=github_status&utm_medium=notification> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4951 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95NPh_dH-gKjvqob--iZTX2dBHqKgks5tLj4NgaJpZM4RgZeb> .

[bors]

⌛ Testing commit a540a39 with merge c6cf5f0218b9d54d63d2eb4a6c158d72eedc25ab...

[bors]

💔 Test failed - status-travis

[alexcrichton]

@bors: retry

[bors]

⌛ Testing commit a540a39 with merge 388e0c476774606596d434eda8b3b2705332cc3d...

[bors]

💥 Test timed out

[alexcrichton]

@bors: retry

[bors]

⌛ Testing commit a540a39 with merge bc35fa6...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing bc35fa6 to master...