Fix issues #4798
Fix issues #4798
Conversation
| @@ -308,7 +308,7 @@ resolve to 1.0.1 inside the repository instead of trying to download a version | |||
| from crates.io. Once 1.0.1 is published on crates.io the `[patch]` section can | |||
| be deleted. | |||
|
|
|||
| It's also worth nothing that `[patch]` applies *transitively*. Let's say you use | |||
| It's also worth nothing that `[patch]` applies at the *top level*. Let's say you use | |||
There was a problem hiding this comment.
This I believe isn't correct, the point of [patch] is to apply transitively to the entire crate graph.
There was a problem hiding this comment.
So the second declaration is the incorrect one? (just a few lines below)
There was a problem hiding this comment.
Sort of. I think the one below just needs to be clarified. The [patch] section can only be defined at the top-level but its effects are transitive throughout the crate graph.
|
☔ The latest upstream changes (presumably #4904) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
patch-1
branch
from
b797e14 to
36601c3
Compare
|
Updated. |
| @@ -308,7 +308,7 @@ resolve to 1.0.1 inside the repository instead of trying to download a version | |||
| from crates.io. Once 1.0.1 is published on crates.io the `[patch]` section can | |||
| be deleted. | |||
|
|
|||
| It's also worth nothing that `[patch]` applies *transitively*. Let's say you use | |||
| It's also worth nothing that `[patch]` applies at the *transitively*. Let's say you use | |||
There was a problem hiding this comment.
Oups, forgot this one...
|
|
||
| In case the dependency you want to override isn't loaded from `crates.io`, you'll have to change a bit how you use `[patch]`: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
This may want to mention "toml" as the language?
GuillaumeGomez
force-pushed
the
patch-1
branch
from
36601c3 to
fb12480
Compare
|
Updated. |
|
@bors: r+ |
|
📌 Commit fb12480 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #4786.