Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cargo login --host with cargo login --index. #4613

Closed
wants to merge 2 commits into from

Conversation

fa7ca7
Copy link
Contributor

@fa7ca7 fa7ca7 commented Oct 12, 2017

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors
Copy link
Collaborator

bors commented Oct 25, 2017

☔ The latest upstream changes (presumably #4506) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

Thanks for the PR! I'm somewhat hesitant to do this as I think we'll probably want to deprecate and remove this flag entirely (both it and a possible --index flag). PRs like #4680 are working with a --registry flag for custom registries.

I'm somewhat hesitant to land a deprecation/rename just before we remove it, however, so perhaps it'd be best to just leave it until custom registries have stabilized?

@fa7ca7
Copy link
Contributor Author

fa7ca7 commented Oct 31, 2017

Hah, I was working last few days on stabilizing of #4206 which is a base for #4680. But seems like I am late)

@fa7ca7 fa7ca7 closed this Oct 31, 2017
@fa7ca7 fa7ca7 deleted the login-index branch October 31, 2017 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants