Encourage tools writers to explicitly pin metadata version #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit 6585dca has been approved by |
|
⌛ Testing commit 6585dca with merge e75253f... |
matklad
force-pushed
the
encourage-explicit-version
branch
from
6585dca to
624493c
Compare
|
@bors: r=alexcrichton |
|
📌 Commit 624493c has been approved by |
bors
added a commit
that referenced
this pull request
Mar 21, 2017
Encourage tools writers to explicitly pin metadata version We do support versioning of metadata, but let's encourage tool's writers to actually use it. They might not realize that this flag exists at all, or they can be too lazy (like myself :( ) to use it. We can also make this flag mandatory, but I think that's a little bit to far.
|
☀️ Test successful - status-appveyor, status-travis |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 22, 2017
Suppress warning introduced by rust-lang/cargo#3841.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 24, 2017
Suppress warning introduced by rust-lang/cargo#3841.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Apr 25, 2017
Suppress warning introduced by rust-lang/cargo#3841.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do support versioning of metadata, but let's encourage tool's writers to actually use it.
They might not realize that this flag exists at all, or they can be too lazy (like myself :( ) to use it.
We can also make this flag mandatory, but I think that's a little bit to far.