-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a publish-build-info command for reporting build results to crates.io #3627
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
I like it! Trying to come up with a comment or critique, but it all seems great to me. My personal preference would be to have AppVeyor configs here as well to copy/paste before merging, but we can always add that after-the-fact too. cc @rust-lang/tools, a nifty command to help us track version compatibility! |
☔ The latest upstream changes (presumably #3682) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #4162) made this pull request unmergeable. Please resolve the merge conflicts. |
@carols10cents was this waiting on a review? Or more coordination from crates.io? |
i need to rebase the crates.io side and i think that should be merged first? |
Ah ok, just wanted to confirm! |
☔ The latest upstream changes (presumably #4680) made this pull request unmergeable. Please resolve the merge conflicts. |
We're going to reopen this in a second lol |
Yeah, my bad, sorry about that! Accidentally pushed |
☔ The latest upstream changes (presumably #5907) made this pull request unmergeable. Please resolve the merge conflicts. |
This goes with rust-lang/crates.io#540. @shepmaster worked on these too :)
This PR adds a cargo command,
publish-build-info
, which allows crate owners to report crate version, rust version, target, and pass/fail to crates.io.The purpose is to enable crate authors to automatically report to potential crate users on the Rust version and platform compatibility of each version of the crate.
The idea is that this command would be added to CI, and an example of configuration for Travis is in the documentation we added. We haven't actually tested that configuration out yet; we wanted to get these PRs in for feedback before we set up crates.io instances that weren't local but that we could publish to :) We want to add Appveyor too, but we want to test the travis configuration first.
We also thought about, but didn't implement:
AnOverwriting is now the default behavior.--overwrite
flag to allow editing of an already-reported-on crate version+rust version+target combination, to allow for correcting errors if reporting manually--target
since there was already support for that flag :)We're excited to hear what anyone thinks, and of course happy to answer questions or make modifications!
test