cargo-install: prefer building artifacts in the system temporary directory #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory and each cargo-install instance creates and uses its own build directory. This allows running several cargo-install instances in parallel. If we fail to create a temporary directory for whatever reason fallback to creating and using a target-install directory in the current directory. closes rust-lang#2606
| let target_dir = if source_id.is_path() { | ||
| config.target_dir(&pkg) | ||
| } else { | ||
| Filesystem::new(config.cwd().join("target-install")) | ||
| if let Ok(td) = TempDir::new("cargo-install") { |
There was a problem hiding this comment.
Should this be target-install instead of cargo-install for consistency with the current/fallback behavior?
|
Yeah probably can't hurt to add tests. You can check out some tests in |
|
Pushed a commit adding tests. Checked that both tests don't pass without this PR. |
bors
added a commit
that referenced
this pull request
Apr 24, 2016
cargo-install: prefer building artifacts in the system temporary directory and each cargo-install instance creates and uses its own build directory. This allows running several cargo-install instances in parallel. If we fail to create a temporary directory for whatever reason fallback to creating and using a target-install directory in the current directory. closes #2606 --- r? @alexcrichton Qs: - Should we preserve the current behavior (`target-install` in `cwd`) as a fallback or remove it and error if we can't create a `TempDir` in `env::temp_dir()`? (we currently error if we can't create `target-install` directory in `cwd`) - Should I add tests for the issues I raised at #2606? If yes, how can I test `cargo-install` parallelism? Lack of "Blocking waiting for file lock on build directory" in the output of the `cargo` commands? or something else?
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and each cargo-install instance creates and uses its own build directory. This
allows running several cargo-install instances in parallel.
If we fail to create a temporary directory for whatever reason fallback to
creating and using a target-install directory in the current directory.
closes #2606
r? @alexcrichton
Qs:
target-installincwd) as a fallback or remove it and error if we can't create aTempDirinenv::temp_dir()? (we currently error if we can't createtarget-installdirectory incwd)cargo-installparallelism? Lack of "Blocking waiting for file lock on build directory" in the output of thecargocommands? or something else?