fix(unit-graph): switch to Package ID Spec #15447
Merged
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
weihanglo
changed the title
weihanglo
approved these changes
Apr 23, 2025
|
Would you mind cleaning up commits? |
brvtalcake
commented
Apr 23, 2025
|
Feel free to force-push or do whatever makes sense :) |
changes summary : - change the `pkg_id` field of `struct SerializedUnit<'a>` to be `PackageIdSpec` instead of `PackageId` - change the unit-graph testcases to match the changes (cleaning previous commits so every commit passes CI checks, as required)
brvtalcake
force-pushed
the
pkgidspec-in-unit_graph
branch
from
918ec15 to
55952a3
Compare
|
OK, it should be better now (I had a bit of trouble figuring out that I just had to force-push it) |
weihanglo
approved these changes
Apr 23, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2025
Update cargo 10 commits in d811228b14ae2707323f37346aee3f4147e247e6..7918c7eb59614c39f1c4e27e99d557720976bdd7 2025-04-15 15:18:42 +0000 to 2025-04-27 09:44:23 +0000 - overriding-dependencies.md: better readability (rust-lang/cargo#15459) - source-replacement.md: fix typo (rust-lang/cargo#15458) - Stabilize automatic garbage collection. (rust-lang/cargo#14287) - Update doctest xcompile flags (rust-lang/cargo#15455) - fix: Suggest similar looking feature names when feature is missing (rust-lang/cargo#15454) - fix(unit-graph): switch to Package ID Spec (rust-lang/cargo#15447) - chore(deps): update cargo-semver-checks to v0.41.0 (rust-lang/cargo#15446) - Implement RFC3695: Allow boolean literals as cfg predicates (rust-lang/cargo#14649) - chore: remove duplicate word in comment (rust-lang/cargo#15437) - Fix formatting of CliUnstable parsing (rust-lang/cargo#15434) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Fixes #15445, where there were still differences between the format of package ids of "
cargo metadataand build JSON messages", and--unit-graphpackage ids.How should we test and review this PR?
Everything compiles correctly (and outputs what's expected). I also fixed the testcases