Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up for deprecated and removed commands #14739

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

This PR is a follow-up of #14679.

  • A new doc page for deprecated and removed commands
  • Remove shell completions for deprecated commands
  • Remove verify-project and read-manifest from cargo --list output.

How should we test and review this PR?

mdbook serve src/doc and read the doc.

I've set up redirections for all removed/deprecated commands to maintain consistency,
though only verify-project really need it I believe.

@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. A-completions Area: shell completions A-documenting-cargo-itself Area: Cargo's documentation Command-git-checkout Command-read-manifest Command-verify-project S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
This includes

* `git-checkout` (removed)
* `read-manifest` (deprecated)
* `verify-project` (deprecated)
Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to r= me when this is ready

@weihanglo
Copy link
Member Author

@bors r=epage

@bors
Copy link
Contributor

bors commented Oct 28, 2024

📌 Commit 886e55b has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
@bors
Copy link
Contributor

bors commented Oct 28, 2024

⌛ Testing commit 886e55b with merge f95eeb6...

@bors
Copy link
Contributor

bors commented Oct 28, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing f95eeb6 to master...

@bors bors merged commit f95eeb6 into rust-lang:master Oct 28, 2024
22 checks passed
@weihanglo weihanglo deleted the cmd branch October 30, 2024 23:13
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2024
Update cargo

18 commits in e75214ea4936d2f2c909a71a1237042cc0e14b07..0310497822a7a673a330a5dd068b7aaa579a265e
2024-10-25 16:34:32 +0000 to 2024-11-01 19:27:56 +0000
- Add more metadata to `rustc_fingerprint` (rust-lang/cargo#14761)
- test(rustfix): switch to a simpler case for dedup-suggestions (rust-lang/cargo#14765)
- chore(deps): update rust crate security-framework to v3 (rust-lang/cargo#14766)
- chore(deps): update rust crate gix to 0.67.0 (rust-lang/cargo#14762)
- fix(util): Respect all `..`s in `normalize_path` (rust-lang/cargo#14750)
- test(doc): Resolve flaky test (rust-lang/cargo#14760)
- refactor(test): Remove dead 'expect_stdout_contains_n' check (rust-lang/cargo#14759)
- add unstable -Zroot-dir flag to configure the path from which rustc should be invoked (rust-lang/cargo#14752)
- docs(resolver): Further v3 prep (rust-lang/cargo#14753)
- fix: track version in fingerprint dep-info files (rust-lang/cargo#14751)
- test: Remove unused msrv-policy (rust-lang/cargo#14748)
- download targeted transitive deps of with artifact deps'  target platform (rust-lang/cargo#14723)
- Remove requirement for --target when invoking Cargo with -Zbuild-std (rust-lang/cargo#14317)
- docs(fingerprint): document the encoding of Cargo's depinfo (rust-lang/cargo#14745)
- Allow build scripts to report error messages through `cargo::error` (rust-lang/cargo#14743)
- fix(publish): Downgrade version-exists error to warning on dry-run (rust-lang/cargo#14742)
- fix: clean up for deprecated and removed commands (rust-lang/cargo#14739)
- Deprecate `cargo verify-project` (rust-lang/cargo#14736)
@rustbot rustbot added this to the 1.84.0 milestone Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. A-completions Area: shell completions A-documenting-cargo-itself Area: Cargo's documentation Command-git-checkout Command-read-manifest Command-verify-project S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants