Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help with [patch.crates.io] #14700

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Help with [patch.crates.io] #14700

merged 1 commit into from
Oct 17, 2024

Conversation

kornelski
Copy link
Contributor

This catches a syntactical mistake in TOML that's easy to make by patching [patch.crates.io] instead of [patch.crates-io].

 error: failed to parse manifest at `Cargo.toml`
 
 Caused by:
   [patch] entry `crates` should be a URL or registry name
+  For crates.io, use [patch.crates-io] (with a dash)
 
 Caused by:
   invalid url `crates`: relative URL without a base

@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2024
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Thanks!

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 17, 2024

📌 Commit b07c611 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2024
@bors
Copy link
Collaborator

bors commented Oct 17, 2024

⌛ Testing commit b07c611 with merge 6f92aaa...

@bors
Copy link
Collaborator

bors commented Oct 17, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 6f92aaa to master...

@bors bors merged commit 6f92aaa into rust-lang:master Oct 17, 2024
22 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2024
Update cargo

7 commits in 8c30ce53688e25f7e9d860b33cc914fb2957ca9a..cf53cc54bb593b5ec3dc2be4b1702f50c36d24d5
2024-10-15 16:43:16 +0000 to 2024-10-18 13:56:15 +0000
- feat: Stabilize MSRV-aware resolver config (rust-lang/cargo#14639)
- Help with `[patch.crates.io]` (rust-lang/cargo#14700)
- test: Migrate publish snapshotting to snapbox (rust-lang/cargo#14642)
- Bump to 0.85.0; update changelog (rust-lang/cargo#14695)
- Fix typo in faq.md (rust-lang/cargo#14696)
- fix(registry): `HttpRegistry` `block_until_ready` returns early when work is still pending (rust-lang/cargo#14694)
- fix(resolver): avoid cloning when iterating using RcVecIter (rust-lang/cargo#14690)
@rustbot rustbot added this to the 1.84.0 milestone Oct 19, 2024
@kornelski kornelski deleted the patchdash branch October 24, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manifest Area: Cargo.toml issues S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants