Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ref): Expand on MSRV #14636

Merged
merged 5 commits into from
Oct 4, 2024
Merged

docs(ref): Expand on MSRV #14636

merged 5 commits into from
Oct 4, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Oct 2, 2024

What does this PR try to resolve?

The need for this has been growing and becomes especially important with the upcoming MSRV aware resolver
We will be making having an MSRV easier so we need to meet those maintainers where they are and help them.

In particular, this covers

  • What setting an MSRV does
  • What "support" in MSRV means, according to the definition we developed during the review of RFC 3537
  • Background and guidance on setting an MSRV policy

How should we test and review this PR?

Additional information

This intentionally leaves out anything related to the MSRV-aware resolver as that will be handled as the feature is stabilized.

@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2024
@epage epage marked this pull request as draft October 2, 2024 20:39
@epage epage force-pushed the msrv-policy branch 2 times, most recently from e114288 to 2a2e32c Compare October 2, 2024 20:49
@epage epage marked this pull request as ready for review October 2, 2024 20:49
@epage epage force-pushed the msrv-policy branch 2 times, most recently from d9d8495 to 42de00c Compare October 3, 2024 18:59
@epage epage force-pushed the msrv-policy branch 2 times, most recently from d4b2d32 to 65b79e9 Compare October 3, 2024 20:55
src/doc/src/reference/manifest.md Outdated Show resolved Hide resolved
src/doc/src/reference/manifest.md Outdated Show resolved Hide resolved
src/doc/src/reference/rust-version.md Outdated Show resolved Hide resolved
src/doc/src/reference/rust-version.md Outdated Show resolved Hide resolved
src/doc/src/reference/rust-version.md Outdated Show resolved Hide resolved
src/doc/src/reference/rust-version.md Outdated Show resolved Hide resolved
src/doc/src/reference/rust-version.md Show resolved Hide resolved
src/doc/src/reference/rust-version.md Outdated Show resolved Hide resolved
@epage epage force-pushed the msrv-policy branch 4 times, most recently from 90ce635 to b48e5f1 Compare October 3, 2024 21:27
@weihanglo
Copy link
Member

Read through this again this morning, this seems good enough to merge. If we'd like to clarify more things or add some examples, we can always deal with that in follow-ups.

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 4, 2024

📌 Commit b48e5f1 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2024
@bors
Copy link
Collaborator

bors commented Oct 4, 2024

⌛ Testing commit b48e5f1 with merge e1179b5...

@bors
Copy link
Collaborator

bors commented Oct 4, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing e1179b5 to master...

@bors bors merged commit e1179b5 into rust-lang:master Oct 4, 2024
22 checks passed
@epage epage deleted the msrv-policy branch October 4, 2024 17:49
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 5, 2024
Update cargo

17 commits in 80d82ca22abbee5fb7b51fa1abeb1ae34e99e88a..ad074abe3a18ce8444c06f962ceecfd056acfc73
2024-09-27 17:56:01 +0000 to 2024-10-04 18:18:15 +0000
- test: Remove the last of our custom json assertions (rust-lang/cargo#14576)
- docs(ref): Expand on MSRV (rust-lang/cargo#14636)
- docs: Minor re-grouping of pages (rust-lang/cargo#14620)
- docs(ref): Highleft whats left for msrv-policy (rust-lang/cargo#14638)
- Fix `cargo:version_number` - has only one `:` (rust-lang/cargo#14637)
- docs: Declare support level for each crate in our Charter / docs (rust-lang/cargo#14600)
- chore(deps): update tar to 0.4.42 (rust-lang/cargo#14632)
- docs(charter): Declare new Intentional Artifacts as 'small' changes (rust-lang/cargo#14599)
- fix: Remove implicit feature removal (rust-lang/cargo#14630)
- docs(config): make `--config <PATH>` more prominent (rust-lang/cargo#14631)
- chore(deps): update rust crate unicode-width to 0.2.0 (rust-lang/cargo#14624)
- chore(deps): update embarkstudios/cargo-deny-action action to v2 (rust-lang/cargo#14628)
- docs(ref): Clean up language for `package.rust-version` (rust-lang/cargo#14619)
- docs: clarify `target.'cfg(...)'`  doesnt respect cfg from build script (rust-lang/cargo#14312)
- test: relax compiler panic assertions (rust-lang/cargo#14618)
- refactor(compiler): zero-copy deserialization when possible (rust-lang/cargo#14608)
- test: add support for features in the sat resolver (rust-lang/cargo#14583)
@rustbot rustbot added this to the 1.83.0 milestone Oct 5, 2024
bors added a commit that referenced this pull request Oct 18, 2024
feat: Stabilize MSRV-aware resolver config

### What does this PR try to resolve?

This includes
- `cargo generate-lockfile --ignore-rust-version`
- `cargo update --ignore-rust-version`

This does not include
- `edition = "2024"`
- `resolver = "3"`

This is part of #9930

### How should we test and review this PR?

### Additional information

This is stacked on top of #14636.  The commits for this PR start with the commit with a title that matches the PR title.

[FCP](#14639 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants