Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gmake on AIX #14323

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Use gmake on AIX #14323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/testsuite/jobserver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ fn validate(_: &str) {
fn make_exe() -> &'static str {
if cfg!(windows) {
"mingw32-make"
} else if cfg!(target_os = "aix") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

As I have mentioned earlier, we are not able to verify if this is the correct fix. Some questions:

  • Is GNU Make always installed as gmake on IBM AIX (I know the g prefix is a convention though)?
  • Would it be more preferable that downstream exclude these tests when running the test suite?

This is for test only and doesn't look bad, so I am not going to block this :)

Copy link
Contributor Author

@bzEq bzEq Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is GNU Make always installed as gmake on IBM AIX (I know the g prefix is a convention though)?

Yes. It's installed via https://www.ibm.com/support/pages/aix-toolbox-open-source-software-downloads-alpha and there will be symbol link named /usr/bin/gmake which links to /opt/freeware/bin/make.

Would it be more preferable that downstream exclude these tests when running the test suite?

Since adding CI for AIX on github is hard, but we also want to deliver the same quality as tier-1 targets, we are maintaining an internal CI on AIX, running almost the same CI tasks(testing, packaging, stable/beta/nightly channel shifting...) as rust-lang org does. So for our strategy, we try our best to upstream changes for AIX, while not to break community's CI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great. Thanks for your reply!

"gmake"
} else {
"make"
}
Expand Down