Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ref): Update unstable docs for msrv-policy #13751

Merged
merged 1 commit into from
Apr 13, 2024
Merged

docs(ref): Update unstable docs for msrv-policy #13751

merged 1 commit into from
Apr 13, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented Apr 12, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2024

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2024
weihanglo
weihanglo reviewed Apr 12, 2024
View reviewed changes
src/doc/src/reference/unstable.md Outdated
Comment on lines 341 to 342
Your project's MSRV is determined by taking the lowest `package.rust-version` set in you workspace.
If there is none set, `rustc -V` will be used to pick up the rust version from rustup's `rust-toolchain.toml`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be tricker to explain the rustc invocation when #13659 is merged. rust-toolchain.toml does not always exist either. I might suggest something like:

Suggested change
Your project's MSRV is determined by taking the lowest `package.rust-version` set in you workspace.
If there is none set, `rustc -V` will be used to pick up the rust version from rustup's `rust-toolchain.toml`.
Your project's MSRV is determined by taking the lowest `package.rust-version` set among all members of your workspace.
If there is none set, the version of rustc Cargo will invoke would be picked as the project's MSRV.

BTW, what does "project" refer to here? 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went in a slightly different direction.

I also did not write this with an eye for what would go in stable documentation. This is meant to help people in using the unstable feature and I don't think we need to block on this being ideal.

@weihanglo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 13, 2024

📌 Commit 079f4d1 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2024
@bors
Copy link
Contributor

bors commented Apr 13, 2024

⌛ Testing commit 079f4d1 with merge ac0f58e...

bors added a commit that referenced this pull request Apr 13, 2024
@bors
Auto merge of #13751 - epage:msrv-docs, r=weihanglo
ac0f58e 
docs(ref): Update unstable docs for msrv-policy
@weihanglo
Copy link
Member

bors is dead?

@bors r-

@bors bors added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 13, 2024
@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 13, 2024

📌 Commit 079f4d1 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Apr 13, 2024
@bors
Copy link
Contributor

bors commented Apr 13, 2024

⌛ Testing commit 079f4d1 with merge 29189d9...

@bors
Copy link
Contributor

bors commented Apr 13, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 29189d9 to master...

@bors bors merged commit 29189d9 into rust-lang:master Apr 13, 2024
21 checks passed
@epage epage deleted the msrv-docs branch April 15, 2024 16:47
@weihanglo weihanglo mentioned this pull request Apr 16, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2024
@bors
Auto merge of rust-lang#124039 - weihanglo:update-cargo, r=weihanglo
803e33a 
Update cargo

11 commits in 48eca1b164695022295ce466b64b44e4e0228b08..6f06fe908a5ee0f415c187f868ea627e82efe07d
2024-04-12 21:16:36 +0000 to 2024-04-16 18:47:44 +0000
- fix(toml): Error on `[project]` in Edition 2024 (rust-lang/cargo#13747)
- feat(update): Include a Locking message (rust-lang/cargo#13759)
- chore(deps): update rust crate gix to 0.62.0 [security] (rust-lang/cargo#13760)
- test(schemas): Ensure tests cover the correct case (rust-lang/cargo#13761)
- feat(resolve): Tell the user the style of resovle done (rust-lang/cargo#13754)
- Make sure to also wrap the initial `-vV` invocation (rust-lang/cargo#13659)
- docs: update `checkout` GitHub action version (rust-lang/cargo#13757)
- Recategorize cargo test's `--doc` flag under "Target Selection" (rust-lang/cargo#13756)
- Reword sentence describing workspace toml for clarity (rust-lang/cargo#13753)
- docs(ref): Update unstable docs for msrv-policy (rust-lang/cargo#13751)
- refactor(config): Consistently use kebab-case (rust-lang/cargo#13748)

r? ghost
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Apr 17, 2024
@bors
Auto merge of #124039 - weihanglo:update-cargo, r=weihanglo
bf4355a 
Update cargo

11 commits in 48eca1b164695022295ce466b64b44e4e0228b08..6f06fe908a5ee0f415c187f868ea627e82efe07d
2024-04-12 21:16:36 +0000 to 2024-04-16 18:47:44 +0000
- fix(toml): Error on `[project]` in Edition 2024 (rust-lang/cargo#13747)
- feat(update): Include a Locking message (rust-lang/cargo#13759)
- chore(deps): update rust crate gix to 0.62.0 [security] (rust-lang/cargo#13760)
- test(schemas): Ensure tests cover the correct case (rust-lang/cargo#13761)
- feat(resolve): Tell the user the style of resovle done (rust-lang/cargo#13754)
- Make sure to also wrap the initial `-vV` invocation (rust-lang/cargo#13659)
- docs: update `checkout` GitHub action version (rust-lang/cargo#13757)
- Recategorize cargo test's `--doc` flag under "Target Selection" (rust-lang/cargo#13756)
- Reword sentence describing workspace toml for clarity (rust-lang/cargo#13753)
- docs(ref): Update unstable docs for msrv-policy (rust-lang/cargo#13751)
- refactor(config): Consistently use kebab-case (rust-lang/cargo#13748)

r? ghost
@ehuss ehuss added this to the 1.79.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
5 participants
@epage @rustbot @weihanglo @bors @ehuss