Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add asserts to catch BorrowMutError's #13651

Merged
merged 1 commit into from
Mar 26, 2024

Commits on Mar 26, 2024

  1. test: Add asserts to catch BorrowMutError's

    This intentionally borrows from `RefCell`s before conditional code
    to try to prevent regressions like rust-lang#13646 without exhaustively
    covering every case that could hit these `BorrowMutError`s with
    complicated tests.
    
    I tested this by ensuring the registry code path panicked before
    rebasing on top of rust-lang#13647.
    Once I rebased, the panic went away.
    
    Co-authored-by: Ed Page <eopage@gmail.com>
    epage authored and weihanglo committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    309cd93 View commit details
    Browse the repository at this point in the history