-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(toml): Expose surce/spans for VirtualManifests #13603
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
edee996
refactor(toml): Remove redundant creation of manifest path
epage 74cdee2
refactor(toml): Clarify which toml we are working with
epage 7cfa2ae
refactor(toml): Leverage cap lints for project warnings, rather than …
epage fa765fb
refactor(toml): Consolidate on a single way to track warnings
epage 914dc14
refactor(toml): Remove unused trim
epage 368ad2b
refactor(toml): Pull nested ws fn out
epage 9b8486b
refactor(toml): Clarify what TomlManifest we are working with
epage a694ea9
refactor(core): Have Manifest track true original_toml
epage 8152bfb
refactor(core): Expose all of the variants of VirtualManifests
epage 0048f2f
refactor(core): Reuse TomlManifest for TomlProfiles
epage c1a53f3
refactor(toml): Don't move lints to verify them
epage 0305ad3
refactor(toml): Pull out TomlManifest to WorkspaceConfig
epage 9882ab3
refactor(toml): Proces unused keys on Manifest
epage 00d542f
refactor(features): Remove redundant is_local
epage 627217a
docs: Fix original_toml doc comments
epage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This additional clone seems unfortunate, though I expect it won't really hurt the performance in normal cases, as it's for virtual manifests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do a small normalization later on. Over time, I will be doing more.