chore: Fix minor grammar nit in command-line help #13602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
A-cli
mrobinson
force-pushed
the
fix-minor-grammar-error
branch
3 times, most recently
from
b43904c
to
ce3b75e
Compare
weihanglo
reviewed
Mar 18, 2024
| @@ -1,5 +1,5 @@ | |||
| {{#option "`--frozen`" "`--locked`"}} | |||
| Either of these flags requires that the `Cargo.lock` file is | |||
| Either of these flags require that the `Cargo.lock` file be | |||
There was a problem hiding this comment.
“Require” should be in singular form, as it agrees with “Either,” which is a singular subject, no?
Suggested change
| Either of these flags require that the `Cargo.lock` file be | |
| Either of these flags requires that the `Cargo.lock` file be |
There was a problem hiding this comment.
Sorry, you're correct. I've updated the PR with this fix.
A *very* minor grammar correction. "Require" used in this way is typically followed by the infinitive.
mrobinson
force-pushed
the
fix-minor-grammar-error
branch
from
ce3b75e
to
8fa25ba
Compare
weihanglo
approved these changes
Mar 19, 2024
|
@bors r+ Thanks for the grammar fix! |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Mar 19, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2024
Update cargo 5 commits in 2fe739fcf16c5bf8c2064ab9d357f4a0e6c8539b..d438c80c45c24be676ef5867edc79d0a14910efe 2024-03-15 21:39:18 +0000 to 2024-03-19 16:11:22 +0000 - refactor(toml): Expose surce/spans for VirtualManifests (rust-lang/cargo#13603) - cargo/init: avoid target.name assignments if possible (rust-lang/cargo#13606) - chore: Fix minor grammar nit in command-line help (rust-lang/cargo#13602) - Bump to 0.80.0; update changelog (rust-lang/cargo#13604) - cargo: prevent dashes in lib.name (rust-lang/cargo#12783) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a very minor grammar mistake. "Require" used in this way is
typically followed by the infinitive. In addition, since "up-to-date" is used
an adjective now it should be hyphenated.
See https://www.merriam-webster.com/dictionary/up-to-date
Testing
I have run
cargo testwithCFG_DISABLE_CROSS_TESTS=1as well ascargo build-manto regenerate the man pages.Fixes #13601.