Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Switch from termcolor to anstream #12751

Merged
merged 7 commits into from
Sep 29, 2023
Merged

refactor: Switch from termcolor to anstream #12751

merged 7 commits into from
Sep 29, 2023
+105 −294

Commits on Sep 29, 2023

  1. chore: Upgrade deps to get latest anstream

    @epage
    epage committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    ab5ebba View commit details
    Browse the repository at this point in the history

  2. refactor: Reuse existing anstream dep for stripping 

    We are already getting `anstream` through `clap`, so this is no extra
cost and let's us drop some dependencies.

The `anstream` implementation is also orders of magnitude faster (last I
benchmarked)
    @epage
    epage committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    c0fd362 View commit details
    Browse the repository at this point in the history

  3. refactor(test): Switch termcolor to anstream

    @epage
    epage committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    7963985 View commit details
    Browse the repository at this point in the history

  4. refactor(shell): Switch termcolor to anstream

    @epage
    epage committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    b3353c8 View commit details
    Browse the repository at this point in the history

  5. feat(shell): Allow colored messages

    @epage
    epage committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    89b2a43 View commit details
    Browse the repository at this point in the history

  6. refactor(report): Don't bother stripping ANSI escape codes 

    `cargo report` calls `Shell::print_ansi_stdout`.  Previously, it didn't
always strip the colors when needed (e.g. `Write` is used).  Now it
does, so don't need to special case this when generating the report.
    @epage
    epage committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    98bba4b View commit details
    Browse the repository at this point in the history

  7. refactor(compile): Remove redundant color stripping 

    These messages will eventually be forwarded to `Shell` which will
strip as needed, making it so we don't need to strip here anymore.
    @epage
    epage committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a770d36 View commit details
    Browse the repository at this point in the history