Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove --keep-going from cargo test/bench #12478

Merged
merged 2 commits into from
Aug 13, 2023

Commits on Aug 11, 2023

  1. feat: remove --keep-going from cargo test/bench

    It confuses people that both `--no-fail-fast` and `--keep-going` exist
    on `cargo test` and `cargo bench` but with slightly different behavior.
    The intended use cases for `--keep-going` involve build commands like
    `build`/`check`/`clippy` but never `test`/`bench`.
    
    Hence, this commit removes `--keep-going` from `test`/`bench` and
    provides guidance of `--no-fail-fast` instead.
    
    If people really want to build as many tests as possible, they can also
    do it in two steps:
    
        cargo build --tests --keep-going
        cargo test --test --no-fail-fast
    weihanglo committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5ae529b View commit details
    Browse the repository at this point in the history
  2. feat: remove completions of --keep-going for bench/test

    To test, simply run:
    
    zsh
    
    ```zsh
    fpath+=$PWD/src/etc
    autoload -Uz compinit
    compinit
    
    cargo t <tab>
    ```
    
    bash:
    
    ```bash
    
    . ./src/etc/cargo.bashcomp.sh
    
    cargo t <tab>
    ```
    weihanglo committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    de8b913 View commit details
    Browse the repository at this point in the history