Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Use 'and' joined summary for install/uninstall #11925

Closed
wants to merge 1 commit into from
Closed

misc: Use 'and' joined summary for install/uninstall #11925

wants to merge 1 commit into from

Conversation

kamilogorek
Copy link

It's a cosmetic change, that modifies how installed/uninstalled crates are listed. When precisely two are installed, it just reads oddly right now IMO.

Note that https://crates.io/crates/and crate is reserved, so there will never be something and and.

A: Summary Successfully installed tauri-cli, trunk!
B: Summary Successfully installed tauri-cli and trunk!
A: Summary Successfully installed tauri, tauri-cli, trunk!
B: Summary Successfully installed tauri, tauri-cli and trunk!

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added Command-install Command-uninstall S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2023
@@ -854,7 +854,7 @@ fn partially_already_installed_does_one_update() {
[FINISHED] release [optimized] target(s) in [..]
[INSTALLING] [CWD]/home/.cargo/bin/baz[EXE]
[INSTALLED] package `baz v1.0.0` (executable `baz[EXE]`)
[SUMMARY] Successfully installed foo, bar, baz!
[SUMMARY] Successfully installed foo, bar and baz!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the test output, I feel like using and makes it harder to quickly scan. Using an oxford comma would help but that doesn't help with the foo and bar (2 item) case.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, makes perfect sense, as it's subjective. I'm fine closing the PR, so no worries :)

@bors
Copy link
Collaborator

bors commented Apr 8, 2023

☔ The latest upstream changes (presumably #11866) made this pull request unmergeable. Please resolve the merge conflicts.

@weihanglo
Copy link
Member

Hey! Thanks for the pull request. By following the discussion above, I'll go ahead and close this. I appreciate the effort making the output more correct. Thanks!

@weihanglo weihanglo closed this Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Command-install Command-uninstall S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants