Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: revive nightly plugin tests to work #11534

Merged
merged 1 commit into from
Jan 4, 2023
Merged

test: revive nightly plugin tests to work #11534

merged 1 commit into from
Jan 4, 2023

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

CI is failing: https://github.com/rust-lang/cargo/actions/runs/3837241733/jobs/6532317777

   Compiling baz v0.0.1 (/home/runner/work/cargo/cargo/target/tmp/cit/t1911/foo/baz)
     Running `rustc --crate-name baz baz/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C embed-bitcode=no -C debuginfo=2 -C metadata=04ecbc4d503298d3 -C extra-filename=-04ecbc4d503298d3 --out-dir /home/runner/work/cargo/cargo/target/tmp/cit/t1911/foo/target/debug/deps -L dependency=/home/runner/work/cargo/cargo/target/tmp/cit/t1911/foo/target/debug/deps`
     Running `rustc --crate-name baz baz/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C panic=abort -C embed-bitcode=no -C debuginfo=2 -C metadata=a079e75a1240be9f -C extra-filename=-a079e75a1240be9f --out-dir /home/runner/work/cargo/cargo/target/tmp/cit/t1911/foo/target/debug/deps -L dependency=/home/runner/work/cargo/cargo/target/tmp/cit/t1911/foo/target/debug/deps`
   Compiling bar v0.0.1 (/home/runner/work/cargo/cargo/target/tmp/cit/t1911/foo/bar)
error: test failed, to rerun pass `--test testsuite`
     Running `rustc --crate-name bar bar/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C embed-bitcode=no -C debuginfo=2 -C metadata=26cdd1af49fe33b5 --out-dir /home/runner/work/cargo/cargo/target/tmp/cit/t1911/foo/target/debug/deps -L dependency=/home/runner/work/cargo/cargo/target/tmp/cit/t1911/foo/target/debug/deps --extern baz=/home/runner/work/cargo/cargo/target/tmp/cit/t1911/foo/target/debug/deps/libbaz-04ecbc4d503298d3.rlib`
error: crate `rustc_ast` required to be available in rlib format, but was not found in this form
  |
  = help: try adding `extern crate rustc_driver;` at the top level of this crate

error: crate `tracing` required to be available in rlib format, but was not found in this form

How should we test and review this PR?

Although I don't understand the internals of plugin mechanism, these additional extern crate should be fine to add.

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2023
@ehuss
Copy link
Contributor

ehuss commented Jan 4, 2023

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 4, 2023

📌 Commit 90d5e6a has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2023
@bors
Copy link
Collaborator

bors commented Jan 4, 2023

⌛ Testing commit 90d5e6a with merge 8c460b2...

@ehuss
Copy link
Contributor

ehuss commented Jan 4, 2023

Looks like this was an intentional change as part of rust-lang/rust#105609.

@bors
Copy link
Collaborator

bors commented Jan 4, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 8c460b2 to master...

@bors bors merged commit 8c460b2 into rust-lang:master Jan 4, 2023
@weihanglo weihanglo mentioned this pull request Jan 4, 2023
Merged
weihanglo added a commit to weihanglo/rust that referenced this pull request Jan 4, 2023
@weihanglo
Update cargo
6306fd3 
8 commits in 2381cbdb4e9b07090f552d34a44a529b6e620e44..8c460b2237a6359a7e3335890db8da049bdd62fc
2022-12-23 12:19:27 +0000 to 2023-01-04 14:30:01 +0000
- test: revive nightly plugin tests to work (rust-lang/cargo#11534)
- Add note to release notes about rejecting multiple registries. (rust-lang/cargo#11531)
- Fix a typo `fresheness` -> `freshness` (rust-lang/cargo#11529)
- Reasons for rebuilding (rust-lang/cargo#11407)
- Asymmetric tokens (rust-lang/cargo#10771)
- Use proper git URL for GitHub repos (rust-lang/cargo#11517)
- Add `registry.default` example (rust-lang/cargo#11516)
- Support vendoring with different revs from same git repo (rust-lang/cargo#10690)

Also update license exceptions and permitted dependencies
for new cargo dependency "pasetors".

A new dependency `getrandom` is added into `rustc-workspace-hacks`,
since it requires feature `js`.
@weihanglo weihanglo deleted the fix-nightly-plugins-tests branch January 4, 2023 16:03
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2023
@bors
Auto merge of rust-lang#106330 - weihanglo:update-cargo, r=weihanglo
659e169 
Update cargo

8 commits in 2381cbdb4e9b07090f552d34a44a529b6e620e44..8c460b2237a6359a7e3335890db8da049bdd62fc
2022-12-23 12:19:27 +0000 to 2023-01-04 14:30:01 +0000
- test: revive nightly plugin tests to work (rust-lang/cargo#11534)
- Add note to release notes about rejecting multiple registries. (rust-lang/cargo#11531)
- Fix a typo `fresheness` -> `freshness` (rust-lang/cargo#11529)
- Reasons for rebuilding (rust-lang/cargo#11407)
- Asymmetric tokens (rust-lang/cargo#10771)
- Use proper git URL for GitHub repos (rust-lang/cargo#11517)
- Add `registry.default` example (rust-lang/cargo#11516)
- Support vendoring with different revs from same git repo (rust-lang/cargo#10690)

Also update license exceptions and permitted dependencies
for new cargo dependency "pasetors".

A new dependency `getrandom` is added into `rustc-workspace-hacks`,
since it requires feature `js`.

r? `@ghost`
@ehuss ehuss added this to the 1.68.0 milestone Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epage epage

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@weihanglo @rustbot @ehuss @bors @epage