Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration in env vars interprets "true" as a boolean, not a string #7780

Closed
alexcrichton opened this issue Jan 8, 2020 · 0 comments · Fixed by #7891
Closed

Configuration in env vars interprets "true" as a boolean, not a string #7780

alexcrichton opened this issue Jan 8, 2020 · 0 comments · Fixed by #7891
Labels
A-configuration Area: cargo config files and env vars

Comments

@alexcrichton
Copy link
Member

This is an unfortunate regression from 1.39.0, but this command will now return an error:

$ export CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUNNER=true 
$ cargo build
error: data did not match any variant of untagged enum Target

where nightly now returns:

$ export CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUNNER=true 
$ cargo +nightly build
error: error in environment variable `CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUNNER`: could not load config key `target.x86_64-unknown-linux-gnu.runner`: error in environment variable `CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUNNER`: could not load config key ` target.x86_64-unknown-linux-gnu.runner`: failed to deserialize, expected a string or array of strings: data did not match any variant of untagged enum Target

This is a bit unfortunate but not necessarily the end of the world. Wanted to make sure it was written down though!

If others run into this I think we may want to pursue a fix, but if no one else runs into this then I think it's fine to close this.

@alexcrichton alexcrichton added the A-configuration Area: cargo config files and env vars label Jan 8, 2020
bors added a commit that referenced this issue Jan 10, 2020
Some small tweaks around error in configuration

Some minor changes I found when investigating #7780
@bors bors closed this as completed in 914e31d Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-configuration Area: cargo config files and env vars
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant