-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parsing cargo:rustc-flags
does not support the -L/libdir
syntax (no spaces between flag and argument)
#7217
Comments
Hi, I've gone ahead and taken a look at this. I believe I fixed the issue in my own fork and would like to write some tests for it. I'm brand new to cargo (and open source contributions in general) and don't really know where these tests would go. Right now I'm thinking Also, judging by the other tests in that file, simply calling the |
Fix #7217: Add support for rustc-flags without spaces between flags and values Hi, I believe this pull request contains a fix for issue #7217. This is my first pull request to any open source project, much less any Rust project. I'm not super familiar with Rust at the moment, so let me know if I should change anything. Also any help/advice you can give me about this PR would be much appreciated! I do have some specific questions: - Is the test I added worthy of being its own test? I basically copied the one above it and remove the spaces between the flags and the values. Should I have added on to the test above it instead? - Would it be better if I directly unit-tested this function in some other test file? - Is the `ureachable!` macro good style?
This removes a workaround for rust-lang/cargo#7217, which is no longer needed since Rust 1.40.0 and which made it impossible to have ICU installed in `~/my-libs/icu` (because of the `-l`).
This removes a workaround for rust-lang/cargo#7217, which is no longer needed since Rust 1.40.0 and which made it impossible to have ICU installed in `~/my-libs/icu` (because of the `-l`).
Problem
Steps
-L/some/dir/local/lib -licui18n -licuuc -licudata
, which is correct as far as flags go, but won't parse.Possible Solution(s)
Perhaps the parsing should be corrected to account for this. And yes, I can replace
-L
with-L
(space at end) and do the same for-l
but would be nice if this worked out of the box.Notes
Output of
cargo version
:The text was updated successfully, but these errors were encountered: